fix(renderer): no_next_padding to fix indentation set to 1 #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cseickel
approved these changes
Jun 9, 2023
This was referenced Jun 9, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
Indentation is broken when parent
indent_markeris not shown in the node since it is the last element in the tree.This happens only and only if value is exactly 1. See the indent of
./src/B/{a,b}.js.= 0= 1= 2(>= 2all works)Expected
When the indent is set to 1, the indent should only show
indent_marker(orlast_indent_marker) so that the indent width will be 1.= 1Main Issue
Closes #924
Detailed Explanation
#864 (comment)
Fix
#864 (comment)